You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
auto-discover local Chrome CDP endpoints from DevToolsActivePort when OPENCLI_CDP_ENDPOINT is unset or set to auto
treat browser-level websocket endpoints as attachable roots and bind them to a real page target before sending Page/Runtime commands
make doctor report CDP mode explicitly and cover browser-level target selection with unit tests
Why
On macOS Chrome exposing DevToolsActivePort, OpenCLI can discover a browser-level websocket like ws://127.0.0.1:9222/devtools/browser/<id> even when the standard /json target listing is unavailable. Before this change, CDP mode assumed it already had a page-level target, so browser commands and opencli doctor could fail before any page interaction.
Validation
npm test -- src/browser/cdp.test.ts src/browser.test.ts
Hi! PR #408 covers similar ground: browser-level WebSocket discovery, page target attach, and DevToolsActivePort fallback. It's been through a few rounds of review and might merge soon. Might be worth checking if there's a gap this PR addresses that #408 doesn't.
Another concrete risk here: CDPBridge.connect() now puts attachToInspectableTarget() inside the same broad try/catch as the best-effort Page.enable setup in src/browser/cdp.ts (around lines 79-87). If the browser-level websocket opens but Target.getTargets, Target.createTarget, or Target.attachToTarget fails, that exception is swallowed and connect() still resolves a CDPPage. That leaves callers with a "connected" page that was never attached to a target, so the first real command fails later and the root cause is hidden. I think attach failure should still reject connect(), with only the post-attach niceties staying best-effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
On macOS Chrome exposing DevToolsActivePort, OpenCLI can discover a browser-level websocket like
ws://127.0.0.1:9222/devtools/browser/<id>even when the standard/jsontarget listing is unavailable. Before this change, CDP mode assumed it already had a page-level target, so browser commands andopencli doctorcould fail before any page interaction.Validation
npm test -- src/browser/cdp.test.ts src/browser.test.tsnpm run build